PrivacyScreenPlugin icon indicating copy to clipboard operation
PrivacyScreenPlugin copied to clipboard

Add IPhone X Support

Open kuhlebrock opened this issue 7 years ago • 3 comments

Description

Check if the device is an iPhoneX and adapt the image names accordingly. Code taken from the cordova-plugin-splashscreen which this plugin is based on. apache/cordova-plugin-splashscreen#146

Related Issue

apache/cordova-plugin-splashscreen#146

Motivation and Context

On an iPhone X the wrong image was selected and stretched. It is now taking the correct image.

How Has This Been Tested?

Tested on emulator and device.

Screenshots (if appropriate):

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [ ] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [ ] All new and existing tests passed.

kuhlebrock avatar Jan 14 '18 23:01 kuhlebrock

I look forward to this change.

lloydmurray avatar Feb 02 '18 15:02 lloydmurray

Are we able to get this merged?

kiwi-josh avatar Feb 20 '18 23:02 kiwi-josh

Guessing @devgeeks isn't supporting this anymore?

thomaswmanion avatar Nov 15 '18 18:11 thomaswmanion