painterro icon indicating copy to clipboard operation
painterro copied to clipboard

Some actions (e.g. pixelizing) can't be undone

Open mbernwieser opened this issue 2 years ago • 2 comments

Describe the bug Some actions can't be undone with the "undo"-button. At least for the following actions it does not work:

  • Pixelizing
  • Croping
  • Rotating

Painterro version 1.2.73

To Reproduce Steps to reproduce the behavior:

  1. Open any image with painterro
  2. Pixelize an area in the image
  3. Try to undo the pixelize-action
  4. Can't be undone

Expected behavior The undo-function should work for every action of the editor

Screenshots image

Browser

  • Chrome v100 - MacBook Air (macOS 12.3.1)
  • Chrome v100 - Linux Mint 20

mbernwieser avatar May 05 '22 13:05 mbernwieser

@mbernwieser oh, thanks, fixed and published new release,

this is sideeffect of https://github.com/devforth/painterro/issues/149 , all tools mentioned are one-timers which always return to select so now it should be handled correctly. Though this undo/redo staff requires a lot of testing, please touch it and let me know whether I did not broke smth else

ivictbor avatar May 05 '22 16:05 ivictbor

@ivictbor wow, thank you very much for the quick fix!

Works just fine!

I think I found two more actions which are not working:

  • any change you do in "settings"
  • clear-action with the trash-bin icon

image

mbernwieser avatar May 06 '22 11:05 mbernwieser