dx-platform icon indicating copy to clipboard operation
dx-platform copied to clipboard

Migrate to `lower-dash-case` in file names across all packages

Open zeihlis opened this issue 6 years ago • 9 comments

Lower case in path input/Input.tsx can cause build fail on CI(Teamcity for example) sometimes because it lets Windows to neglect mistaken font case and also it doesn't look like consistent naming of platform components.

  • check all packages
  • force casing with a tslint/eslint rule (depends on the package used)

zeihlis avatar Oct 17 '18 17:10 zeihlis

General recommendation is to use lower-dash-case for all files

raveclassic avatar Oct 17 '18 18:10 raveclassic

I suggest creating codemod. It will make a migration to the new version of dx-platform easier.

sutarmin avatar Oct 23 '18 06:10 sutarmin

I suggest creating codemod. It will make a migration to the new version of dx-platform easier.

hmmmm

may be there are some node library? Python seems strange dependency for such operations.

mankdev avatar Oct 28 '18 09:10 mankdev

I don't find python strage for such operations. But we with @zeihlis disscussed offline that maybe there is no need for complex thing like codemod, we can just write find-replace script in plain node and publish it as gist or something :)

sutarmin avatar Oct 28 '18 10:10 sutarmin

closing in favor of #145

raveclassic avatar Sep 04 '19 14:09 raveclassic

After all decided to do this separately after #145

raveclassic avatar Sep 05 '19 12:09 raveclassic

After all decided to do this separately after #145

I think it makes sense to do that simultaneously with #145, why not?

sutarmin avatar Sep 05 '19 15:09 sutarmin

@sutarmin #145 is on hold until it's clear how new "design system" project will impact current platform. Perhaps wasting resource on migration of existing kit which may become incompatible with a new one is pointless.

raveclassic avatar Sep 05 '19 15:09 raveclassic

Taking that into account I should note that it may be possible to apply these changes before #145 . That's why it's separate

raveclassic avatar Sep 05 '19 15:09 raveclassic