dx-platform icon indicating copy to clipboard operation
dx-platform copied to clipboard

Bugfix/ignore mouse up outside dom node

Open pm-Egor-Genning opened this issue 4 years ago • 2 comments

Helps to avoid mouse-up clicks made on target dom-node but dragged outside of it Behavior For example when RootClose is wrapped around resizable/draggable element which is limited by some maxWidth or maxHight dragEnd/mouseUp event triggers onRootClose event. I think it should be avoided by comparing targets (event.target mouseDown to event.target mouseUp) Also added demo page here.

The issue in false triggering onRootClose after drag ends and mouse beyond the element borders

pm-Egor-Genning avatar Mar 16 '20 05:03 pm-Egor-Genning

Hi, @pm-Egor-Genning, thanks for the PR. Before we start the discussion regarding the content of this PR I'd like to ask what issue does it solve? Could you provide some STR or demo with reproduction?

raveclassic avatar Mar 16 '20 08:03 raveclassic

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Egor Genning seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

dxCLA avatar May 18 '21 10:05 dxCLA