devendrn
devendrn
@faizul726 when you are free later, check if that sun artifact happens with fully transparent sun texture.
@faizul726 does this artifact happen when you set `mg8` to `0.0`? ```diff # src/newb/functions/sky.h - float mg8 = (g8.x+g8.y)*mask*(1.0-0.9*env.rainFactor); + float mg8 = 0.0; ```
@faizul726 are you sure you applied the change properly? Try again. If it still shows up, try with this change instead: ```diff # src/newb/functions/sky.h - vec2 g = 0.5 -...
Just a reminder that there are several visual changes. Feedback is needed for me to know whether these changes are moving in the right direction or wrong direction and no...
@faizul726 try testing with this change: ```diff # src/newb/functions/sky.h - vec2 g = 0.5 - 0.5*vec2(dot(env.sunDir, viewDir), dot(env.moonDir, viewDir)); + vec2 g = vec2_splat(1.0); ```
Maybe clamping this value could fix this issue. @faizul726 Try this: ```diff # src/newb/functions/sky.h - vec2 g = 0.5 - 0.5*vec2(dot(env.sunDir, viewDir), dot(env.moonDir, viewDir)); + vec2 g = clamp(0.5 -...
Pending to address review changes