shake
shake copied to clipboard
Flutter 3.14.4, AGP 8, Dart 3, `sensors_plus: ^3.0.3`
Essentially this PR combines the open version-update PRs into one and adds some general maintenance on top.
- [x] Remove
android
folder to shut up the linter about deprecated embedding - [x] Add
flutter_lints
- [x] Remove some more autogenerated files via .gitignore
- [x] Regenerate the example project
- [x] Adds compatibility with Dart 3 #25
- [x] Adds compatibility with AGP 8 by updating to
sensors_plus: ^3.0.3
#27 - [x] Adds compatibiliy with Flutter 3.13.4 (#27 doesn't have that because upper limit too low)
@ziqq I know it's a waste to essentially recreate your PR, but we need a stable fork that we can rely on anyway, so here it is.
shake:
git:
url: https://github.com/dieringe/shake
ref: dieringe
@deven98 Do you plan on reviewing the open PRs anytime soon?
Hi Philipp,
Thanks so much for the PR. My apologies for this repository being unmaintained for a bit, I was dealing with a few personal issues. I will have this PR reviewed and the new version launched by tomorrow.
Thanks so much for the contribution and I'll do more to support the repo going ahead.
Np. When reviewing, checking the lowest flutter version you want to support makes the most sense (if u had to pick one), but take your time (esp with personal issues!)
Hi @deven98, if you need any help maintaining the repo you can add me as a contributor.
@deven98 can you perhaps bump to sensors_plus to 4? So we can use flutter 3.16
@deven98 I've submitted a PR for you, that enables support for 3.16 flutter version by supporting sensors_plus v4:
https://github.com/dieringe/shake/pull/1
@simplenotezy I just built our project with Flutter 3.16.2 & the current state of the PR (ie sensors_plus v3.0.3) and everything seems to build & run just fine.
In what way was v3 incompatible with Flutter 3.16? Which 3.16.x did you use?
Hello, @deven98! Any news with reviewing this one? Or maybe you need help with reviewing it?
Hi @deven98. Kindly pinging to remind that the users of this package still wait for a new version to come in. Do you need any help with updating the package?
Hi @deven98, are there any plans on merging this at some point? Is there some way to assist you?
Due to the old version of sensors_plus
, people have started to run into issues like this one:
- https://github.com/fluttercommunity/plus_plugins/issues/2471#issuecomment-1868863464
The solution is to upgrade the sensors_plus
version. Since this package seems to be dead anyway, we've decided to switch to shake_gesture
. Our fork will still be available for the foreseeable future, in case someone decides to pick this up again.
You can just add ShakeDetector class in your app codebase. This package is just a single class.
@FeodorFitsner I saw that too, but with shake_gesture
, there's no dependency to sensors_plus
at all. No idea what's better here, but since they're all pretty much interchangeable anyway it probably doesn't matter what you pick in any given situation. Our decision was: fewer and smaller dependencies is better, but "id rather have a bigger, but well maintained dependency" is definitely also a valid approach. I guess we'll see what the future brings :)
Will take a look at shake_gesture
. Also, there is Feedback service introduced in Flutter 3.24. Don't know if it provides the same/more/less functionality though.
Scratch that - it's for haptic feedback 🫣