lonboard icon indicating copy to clipboard operation
lonboard copied to clipboard

Add ESLint

Open vgeorge opened this issue 1 year ago • 4 comments

At the moment, we have Prettier formatting checks and TypeScript checks, but not ESLint checks. Adding ESLint would help us improve JavaScript code quality and maintain consistency across the codebase.

cc @kylebarron @batpad

vgeorge avatar Jul 10 '24 13:07 vgeorge

I'm happy to do this. Do you have any opinions about newer alternatives like oxlint?

kylebarron avatar Jul 10 '24 18:07 kylebarron

This is the first time I'm hearing about oxlint, it looks very interesting. My main concern is whether it has good integration with VSCode. If the development experience is similar to using ESLint, I think we can give it a try.

vgeorge avatar Jul 11 '24 10:07 vgeorge

@kylebarron I looked into oxlint, it seems very bleeding edge. I created an oxlintrc.json file with the no-console and no-unused-vars rules enabled, but the oxc VS Code extension isn't able to pick it up.

vgeorge avatar Jul 29 '24 12:07 vgeorge

That's fine; a PR to add eslint would be great

kylebarron avatar Jul 29 '24 13:07 kylebarron