preact-redux icon indicating copy to clipboard operation
preact-redux copied to clipboard

(chore) Add support for preact x

Open cristianbote opened this issue 6 years ago • 8 comments

This adds support for preact x but depends on this PR from preact https://github.com/preactjs/preact/pull/1901. After that's merged and released we could merge this one as well.

~Adds +3.71kB 😞 more than double it's current size~ ~Adds +0.89kB 😄 now we're talking~ Adds +0.98kB 🤔

cristianbote avatar Aug 28 '19 08:08 cristianbote

This will fail until https://github.com/preactjs/preact/pull/1901 is merged

cristianbote avatar Aug 28 '19 08:08 cristianbote

This is gonna be working when https://github.com/preactjs/preact/pull/1924 it's gonna get released

cristianbote avatar Sep 10 '19 20:09 cristianbote

Also this updates the react-redux version and redux with the latest ones.

cristianbote avatar Oct 03 '19 08:10 cristianbote

Folks will be glad to have this working in X. One question still in my mind though: do we know why aliasing react:preact doesn't work, instead requiring all of compat? I'd really love to quantify that delta.

developit avatar Oct 07 '19 17:10 developit

Hey @developit that's a great point! Unfortunately it seems that the build size increases if I would add the imports by hand and re-export them. 🤷‍♂

cristianbote avatar Oct 07 '19 21:10 cristianbote

@cristianbote @marvinhagemeister Any ideas on when this might be released? Would really like to upgrade to Preact X.

Many thanks

jahilldev avatar Jan 31 '20 12:01 jahilldev

@jhdevuk it's awaiting Jason's review. It's on his todo list 👍

cristianbote avatar Jan 31 '20 15:01 cristianbote

Ok, well, what are the alternatives? Where to get Provider and connect from?

adminy avatar Dec 09 '21 19:12 adminy