mitt icon indicating copy to clipboard operation
mitt copied to clipboard

feat: added a signal for unsubscribing on abort

Open Agnaev opened this issue 1 year ago • 0 comments

What is the purpose of this pull request? (put an "X" next to an item)

  • [ ] Documentation update
  • [ ] Bug fix
  • [X] Feature
  • [ ] Code style update (formatting)
  • [ ] Refactoring (no functional changes)
  • [ ] CI related changes
  • [ ] Other, please explain:

What changes did you make? (Give an overview)

I added an optional parameter to the "on" function that can unsubscribe when an abortion event occurs.

Is there anything you'd like reviewers to focus on?

I don't know if it was worth adding SubscribeParams to the function signature on(type: '*'...)

Does this PR introduce a breaking change? (What changes might other developers need to make in their application due to this PR?)

This pull request does not contain any bracking changes.

Agnaev avatar Dec 14 '24 10:12 Agnaev