Jason Miller

Results 1173 comments of Jason Miller

Need to take a peek at what Chrome is doing under the hood here. It seems like it's flat-out replacing Text nodes, but that is really odd. It should just...

I think we might have to wait for the next version of Preact to fix this, because right now we store too much state in the DOM.

I would suggest maybe turning off auto translation. Not really sure of a fix, this is kinda a Chrome bug

Hi all, I finally got some time to write up a resilient solution to this: https://gist.github.com/developit/3e807962630ddbd4977cbd07b597f24f It intercepts Google Translate when it goes to replace Text nodes with its elements,...

I think the size might be better now if we drop the last 1 or 2 .some() loops. I can try and merge into this PR

This all looks good (and like a boatload of work, nice job). One thing that was gnawing at me as I read through though: what was the reason for moving...

Hmm - this is sortof a fluke in both libraries TBH. React wipes out Prism's injected HTML because they use `.textContent` to assign the text of Elements with a single...

Yeah, kinda thinking that as well. Maybe the better option here would be to have this move into the extracted class components implementation once that's landed? One other option (not...

Please use this patch: https://gist.github.com/developit/3e807962630ddbd4977cbd07b597f24f I've spoken to the Translate team about this and suggested fixes, but it will take a long time.

@lvzegeng - sorry, I forgot to include the import. I have updated the Gist, it should work now. Just import this before any rendering happens: ```js import { render }...