Jason Miller

Results 1173 comments of Jason Miller

I will try to publish the recursive preset fix ASAP.

@brigand Correct, the current version of `modify-babel-preset` does not support recursive transformations. Since the `stage-0` `stage-1` or `stage-2` babel presets all rely on recursion (eg: stage-1 includes 2, which includes...

@brigand Just a note, I've published `modify-babel-preset@beta` (2.0.0), which should support what you posted.

@brigand Do you have `babel-preset-stage-1` installed directly in `/Users/fb/github/client2`, or is it installed within `babel-preset-stage-0`?

@nodegin nice work! It's even using `modify-babel-preset` 😍

Ah - so it was broken when using `modify-babel-preset` `1.x`, which lead me down the rabbit hole that resulted in `2.x`, but I never went back and updated it haha.

Try replacing your preact.config.js with this: ```js export default (config, env, helpers) => { config.optimization.splitChunks.minChunks = 1; } ```

Should this issue be migrated to the `preact-cli` repo?

Not sure how I managed to make the Service Worker tests fail with this PR.