asyncro
asyncro copied to clipboard
Add TS typings
Note: these typings will only work with TS 2.8+, as they make use of Conditional types to infer the return types of async functions.
@yenbekbay It might be wise to hold off on merging typings that require 2.8+ at this point. I think a lot of people are still on 2.7, myself included (2.8 is broken on my projects).
I wonder - do you think it'd be worth doing a PR without the conditional types in the interim?
FWIW I've picked up TypeScript now and would be happy to hack on porting this library over to be written in TS if that's interesting to you.
Maybe you can first publish a @types
version? @yenbekbay
@fimars When will you accept whit PR? Very useful
@Nemmo I am not maintaining this project. This PR is as @developit said, some of the broken changes may not be merged now. Maybe you can make a new PR. 🤔
There is no any broken changes cause it is just typing definitions that allows to use that library in TypeScript projects.
It might be wise to hold off on merging typings that require 2.8+ at this point. I think a lot of people are still on 2.7, myself included (2.8 is broken on my projects).
I wonder - do you think it'd be worth doing a PR without the conditional types in the interim?
@Nemmo author said.