app-builder icon indicating copy to clipboard operation
app-builder copied to clipboard

fix: Return size info when converting icon

Open 0xjac opened this issue 4 years ago • 2 comments

Closes #42

@develar I had the same problem as described in #42 with packaged app which had an icon with in the wrong 0x0 directory. This should return the right size for all formats (icns, ico, set).

0xjac avatar Oct 24 '21 22:10 0xjac

@develar When will this be merged? I am having same problem.

hanjukim avatar Jan 26 '22 04:01 hanjukim

@hanjukim if it helps until this is merged, you can have a look at the fix I used here (assuming you are also using electron builder) which essentially fulfills the promise early and then goes over all the icon sizes to replace any size of 0 with an hard-coded value.

@develar I'm sure you're busy, but if there is anything I can do to assist with to merge this PR let me know. :slightly_smiling_face:

0xjac avatar Feb 06 '22 23:02 0xjac