devcows
Port to Boostrap 4
Do you have an appetite to move to the Bootstrap 4 version or hold it as a dev branch? We want to loosely track the upstream version.
There's a known issue this port. Highlighting of active tags does not work. I cannot find the CSS class to do this in the new Boostrapious Universal distribution.
Just following up to see if you’d be interested in this PR or if it’s better for us to maintain the Bootstrap 4 version as a fork.
I know the eslint task failed. As best I can tell, the JavaScript files it complains about are basically the same ones already in the repo. Also, I tested this using the example site. Was anyone else able to test the branch on their machine?
Just following up to see if you’d be interested in this PR or if it’s better for us to maintain the Bootstrap 4 version as a fork.
I'm not a maintainer of this theme but I strongly assume that your efforts to move it to bootstrap 4 are welcome... @ryanfox1985 ?
Was anyone else able to test the branch on their machine?
I'll have a look at it in the next few days!
(...) if it’s better for us to maintain the Bootstrap 4 version as a fork
Basically, I think the changes are so extensive that it would be appropriate to have this bootstrap 4 port in a separate repository (at least for the time being). But I wonder what the maintainers here think, @ryanfox1985 @GeorgeWL @adrianmo ?
I'm not sure about this feature, how to manage it, what is the best.
Time ago I realized the authors from Universal theme have updated the theme and it's not easy to apply the new updates to the current theme.
Perhaps a new main branch or directly a new project.
So, I’m happy to put this in a new repo. What I didn’t want to do is fork this without the consent of current maintainers. My preference is to fork it to hugo-universal-theme-2/hugo-universal-theme-2 rather than under our company. I’d also like to make some changes suggested in the current issue backlog, like shortcodes and managing images as resources rather than bare links. If there are no objections I’ll start the fork.
I think the best is create a master_v2 in the same repository. And the release names use:
- 1.X.X to refer to version v1
- 2.X.X to refer to version v2
etc...
I'd recommend to create a fresh repo as proposed by @varnerac (like hugo-universal-theme-2/hugo-universal-theme-2). Too much stale stuff around here (like open PRs from mid-2017...), therefore a fresh start seems appropriate to me. Just my 5 cents :)
I'm not agree, if you take a look to other public repositories the different versions are in the same repository.
example jquery:
I'm not agree (...)
No offence, but during the last two years there were periods during which almost no maintaining was done here. Which causes people to regularly place comments like this one.
But if you give appropriate write access to @varnerac , putting the bootstap 4 port into a master_v2 branch inside this repo seems fine to me, too. :wink:
@salim-b , sadly you are right, during the last two years this repository was no longer maintained but things can change.
Last months this repository was very active:
- https://github.com/devcows/hugo-universal-theme/releases
- I send a invitation to two new maintainers.
So let's see if we can maintain the repository in a good direction.
I send a invitation to two new maintainers.
Ok, thank you! I can't promise anything but as long as I'll be using this theme myself I'll try to help here :)
Let me know if this works. I do not intend to change the CSS for .tag-cloud a.active at the moment. I will go back to Ondrej and see if he wants to fix it upstream. If so, I'll imitate how he fixes it upstream.
Error: add site dependencies: load resources: loading templates: "/Users/travis/build/devcows/hugo-universal-theme/layouts/partials/footer.html:65:1": parse failed: template: partials/footer.html:65: unexpected {{end}}
on the latest Travis Build of this.
@GeorgeWL I just fixed that in my branch here
I am not sure why this PR hasn't picked it up and re-run Travis on it. My merge commits, which I lazily did on GitHub UI, botched the footers.
@GeorgeWL Okay, if you click on "Details" on the TravisCI check, you'll see my latest commit passes. Unsure why it's not showing in the GitHub UI.
Please don't merge this yet. While porting our site to the Bootstrap 4 version, we found some errors in the carousel.
So, it depends on the definition of done. This works for the example Hugo project. However, it needs improvements for features not tested in the example app. Is the definition of done working with the example app, or works with everything?
This has been stale for some time now; is this going to be picked up again by someone? I'm not too familiar with the bootstrap upgrade, but I do know that version 5 is out and version 3.3.7 has has some CVE's at the moment that are not going to be fixed: https://security.snyk.io/package/npm/bootstrap. It might be useful to get this PR ongoing
