images icon indicating copy to clipboard operation
images copied to clipboard

Use official features to assemble official devcontainers

Open mering opened this issue 2 years ago • 5 comments

In order to reduce maintenance and increase the number of users of devcontainer features (from https://github.com/devcontainers/features and https://github.com/devcontainers-contrib/features) it would be great if the provided official images would the base image with a set of features added on top. If some features are missing (like C++), add them.

mering avatar Jul 23 '23 09:07 mering

Hey @mering! Many of our images do utilize Features (one example) where it makes sense. All of the images in this repo are built with the dev container CLI and the source of truth for the images is the associated devcontainer.json.

Let me know if i'm missing some nuance to your question, but I believe we're already employing your suggestion :)

joshspicer avatar Jul 24 '23 04:07 joshspicer

I would like to assemble a dev container for C++ and Python. While there is a great Python feature which is also used in the Python image, there is none for C++ and the C++ image is installing them manually in the Dockerfile. Same manual installation in the universal image.

mering avatar Jul 24 '23 08:07 mering

Thanks for opening @mering!

We seek to keep the set of images and features we host in the dev containers org relatively slim, to avoid too heavy a maintenance burden, and this way the experts in various languages or toolsets have greater ownership over them and can update them more freely!

As it sounds like this is a request for additional features in the dev containers org, I don't anticipate us taking on many more here.

Please let us know if you have other questions, and thanks for your feedback and thoughts!

bamurtaugh avatar Jul 27 '23 22:07 bamurtaugh

to avoid too heavy a maintenance burden

This is exactly why I am proposing this: Instead of having to maintain the same C++ toolchain in multiple images, it would be maintained in only one feature owned by the experts in the C++ language.

mering avatar Jul 28 '23 09:07 mering

FYI: there are now community features for CMake, LLVM and vcpkg.

mering avatar Aug 22 '23 08:08 mering