devcontainers.github.io icon indicating copy to clipboard operation
devcontainers.github.io copied to clipboard

Add dotnet-node

Open sebdanielsson opened this issue 11 months ago • 3 comments

What type of PR is this?

  • [x] Add a new dev container collection
  • [ ] Update to an existing dev container collection
  • [ ] Documentation/spec update
  • [ ] Other containers.dev site update (UX, layout, etc)

Description

This PR adds a devcontainer for developing web apps using dotnet for the backend and Node.js for the frontend.

Collection checklist

If your PR contributes a new collection, please utilize this checklist:

  • [x] Collection name
  • [x] Maintainer name
  • [x] Maintainer contact link (i.e. link to a GitHub repo, email)
  • [x] Repository URL
  • [x] OCI Reference
  • [x] I acknowledge that this collection provides new functionality, distinct from the existing collections part of this index.

sebdanielsson avatar Feb 03 '25 16:02 sebdanielsson

Hi @sebdanielsson ,

Thanks for the PR. Would you kindly modify the main Readme file (https://github.com/sebdanielsson/devcontainers/blob/main/README.md) of the repo with relevant details.

With Regards, Kaniska

Kaniska244 avatar Feb 19 '25 15:02 Kaniska244

Hi @sebdanielsson ,

Thanks for the PR. Would you kindly modify the main Readme file (https://github.com/sebdanielsson/devcontainers/blob/main/README.md) of the repo with relevant details.

With Regards, Kaniska

Thanks for the review! Should be fixed now👍

Sebastian

sebdanielsson avatar Feb 23 '25 12:02 sebdanielsson

Change approved. This can be merged.

Kaniska244 avatar Feb 24 '25 14:02 Kaniska244

Just rebased.

sebdanielsson avatar Feb 25 '25 19:02 sebdanielsson

Approved! Sorry, but you'll have to fix the merge conflicts again

No problems. That was messy. Closed in favor of #544

sebdanielsson avatar Apr 09 '25 18:04 sebdanielsson