cli icon indicating copy to clipboard operation
cli copied to clipboard

devcontainer exec does not always propagate SIGTERM to docker exec

Open akosyakov opened this issue 1 year ago • 1 comments

Steps to reproduce:

  • Run devcontainer exec without pty, for instance:
devcontainer exec --container-id 1234abcdefgh -- sleep infinity > /dev/null 2>&1
  • Check that on the host machine and inside the container you have infinity sleep process: ps -auxf |grep "infinity"
  • Interrupt devcontainer exec with SIGTERM, i.e. kill the process or just interrupt the terminal.
  • Check on the host machine the docker process is gone, but inside the container infinity sleep is dangling.

It seems docker exec is terminated without SIGTERM, leading to ungraceful termination.

akosyakov avatar Sep 05 '24 10:09 akosyakov

This seems to be https://github.com/moby/moby/issues/9098.

chrmarti avatar Sep 05 '24 11:09 chrmarti