ci icon indicating copy to clipboard operation
ci copied to clipboard

Add `cacheTo` argument to `ci` action

Open sebst opened this issue 1 year ago • 10 comments

Added the argument cacheTo to the action (#299) so that a cache image can be written to a registry.

sebst avatar Sep 02 '24 15:09 sebst

@microsoft-github-policy-service agree

sebst avatar Sep 02 '24 15:09 sebst

Thanks for the PR! Left a few comments.

Thanks for having a look. I'll address those comments!

sebst avatar Sep 03 '24 12:09 sebst

Any update?

sebst avatar Sep 18 '24 14:09 sebst

Thanks, overall it looks good.

Left one comment

Thanks! Fixed the typo

sebst avatar Oct 08 '24 22:10 sebst

Ensure you have run scripts/build-local.sh

@sebst Can you help fix the failing action, see here

samruddhikhandale avatar Oct 08 '24 23:10 samruddhikhandale

Ensure you have run scripts/build-local.sh

@sebst Can you help fix the failing action, see here

Done

sebst avatar Oct 09 '24 08:10 sebst

@samruddhikhandale could you please restart the pipeline to see if the last commit fixes the issue?

sebst avatar Oct 10 '24 16:10 sebst

Can this be merged now?

@samruddhikhandale @chrmarti @stuartleeks @bamurtaugh

sebst avatar Oct 14 '24 11:10 sebst

Hi @sebst, thanks for your patience. We are waiting for another review from @chrmarti, we'd merge shortly. Thanks!

samruddhikhandale avatar Oct 14 '24 18:10 samruddhikhandale

Just a friendly reminder.

@samruddhikhandale @chrmarti @stuartleeks @bamurtaugh

sebst avatar Oct 22 '24 12:10 sebst

Just another friendly reminder.

@samruddhikhandale @chrmarti @stuartleeks @bamurtaugh

sebst avatar Nov 04 '24 16:11 sebst

Hi @sebst, thanks for your patience.

We are waiting for another review from @chrmarti, we'd merge shortly. Thanks!

Is there any chance we get that merged?

@chrmarti

sebst avatar Nov 09 '24 13:11 sebst

@chrmarti - it looks like the PR feedback has been addressed. Do you have time to re-review?

stuartleeks avatar Nov 29 '24 16:11 stuartleeks

@chrmarti - it looks like the PR feedback has been addressed. Do you have time to re-review?

Would be nice!

sebst avatar Dec 10 '24 13:12 sebst

@samruddhikhandale @chrmarti @stuartleeks @bamurtaugh

This PR is open for more than 3 months now but it's just a small change.

Is there anything I could do on my end to get this merged?

Appreciate any feedback!

sebst avatar Dec 12 '24 14:12 sebst