react-fretboard icon indicating copy to clipboard operation
react-fretboard copied to clipboard

styled-components as peerDependency

Open devboell opened this issue 6 years ago • 5 comments

There's an issue with having two instances of styled-components running at the same time. For now I put it in webpack externals, but I'd rather not force a user to install styled-components if they are not using it themselves.

devboell avatar Apr 15 '18 06:04 devboell

Hi @devboell great to get to know your project I'm trying to use it but I got the error you describe above.

$ yarn add react-fretboard yarn add v0.27.5 [1/4] Resolving packages... [2/4] Fetching packages... [3/4] Linking dependencies... warning "[email protected]" has unmet peer dependency "styled-components@^3.2.3". [4/4] Building fresh packages... success Saved 1 new dependency. └─ [email protected] Done in 4.62s.

Is there a workaround for this? pretty new to react and new webpack setup thing.

alexkilla avatar Jan 17 '19 06:01 alexkilla

Hi @alexkilla, it should work when you install styled-components in your own project. Have you tried that?

devboell avatar Jan 18 '19 06:01 devboell

Not working for me with a simple example: https://codesandbox.io/s/nervous-albattani-1w35z?file=/src/App.js:113-194

ccorcos avatar Oct 31 '20 16:10 ccorcos

@ccorcos I don't know what is going on here, seems codesandbox is looking for styled-components in the wrong place.

devboell avatar Nov 01 '20 09:11 devboell

Hi @devboell this library looks fantastic and would be great for what I'm working on, but I'm running into the same exact issue as everyone else. styled-components is breaking this project.

jordanforbes avatar Oct 19 '22 15:10 jordanforbes