Wikitten icon indicating copy to clipboard operation
Wikitten copied to clipboard

[css] Tables render without padding/margin

Open bong0 opened this issue 9 years ago • 7 comments

As in this screenshot from a wiki running the master.zip from 8f32c0b5bedb1e6aeb93cbc2226d8781d3f3ab5d the table css leads to bad/unreadable rendering of table cells. table source and rendered html

What would be the effort to change this to something like in mdwiki?

bong0 avatar Aug 03 '15 11:08 bong0

I assume what's missing is class="table" on the <table> element.

asbjornu avatar Sep 07 '15 22:09 asbjornu

I am not sure if we can make Markdown to add extra classes, but we can redefine table {} in CSS right. :)

praveenscience avatar Mar 03 '16 10:03 praveenscience

If we control the Markdown to HTML conversion pipeline or can extend it somehow, we can add class="table" to all <table> elements, no? That's what would be required to have the Bootstrap style added to it.

asbjornu avatar Mar 04 '16 13:03 asbjornu

Won't that be against the implementation of original markdown parser? Also also I believe you can add extra features with GFM. I am gonna implement that soon.

praveenscience avatar Mar 04 '16 15:03 praveenscience

FYI: I'm not evaluating wikitten anymore but switched to a dokuwiki based solution. It has pretty nice markdown support and also one fairly good bootstrap theme.

bong0 avatar Mar 05 '16 17:03 bong0

@praveenscience The parser shouldn't be involved in this at all. Adding class="table" would be done in the rendering of whatever the parser creates (an AST, I assume) from the Markdown markup. If it's possible to add a plugin to the rendering pipeline, that would be an elegant and simple solution.

asbjornu avatar Mar 07 '16 13:03 asbjornu

@asbjornu Agreed. There's a plan of using Parsedown instead of the original markdown, so this opens up to so many possibilities. I will try to check with the PD guys, if there's a possibility of adding extra class. :smile:

praveenscience avatar Mar 07 '16 13:03 praveenscience