WeblWabl comments

Results 63 comments of


                                            WeblWabl

Update `concat_ws` scalar function to support `Utf8View`

@tshauck can do!

Update `concat_ws` scalar function to support `Utf8View`

I have a PR out for https://github.com/apache/datafusion/pull/12224 Will wait for that to get a review then work on this so I can adapt the changes here. 👍

Fix: Internal error in regexp_replace() for some StringView input

> There are a few things I noted when I reviewed this pull request, some of which may be good to either fix here or in other tickets/PRs: > >...

Fix: Internal error in regexp_replace() for some StringView input

@alamb not sure if you have eyes on this but its a `StringView` related bug 🫡

Internal error in `regexp_replace()` for some StringView input (SQLancer)

take

Internal error in `regexp_replace()` for some StringView input (SQLancer)

Disregard my closed PRs 😅 I accidently committed a `kind` binary that was in my DF folder 😆

Implement fast min/max accumulator for binary / strings (now it uses the slower path)

@alamb is there anyone working on this + is this issue still relevant? I would love to tackle it as it seems like an interesting feature/optimization.

Implement fast min/max accumulator for binary / strings (now it uses the slower path)

> > @alamb is there anyone working on this + is this issue still relevant? I would love to tackle it as it seems like an interesting feature/optimization. > >...

Implement fast min/max accumulator for binary / strings (now it uses the slower path)

take

Implement fast min/max accumulator for binary / strings (now it uses the slower path)

> > > while working on #12092 it turns out that Min / Max on BinaryView and StringView are suuuuper slow. > > > > > > Fixed in #12575,...