volder icon indicating copy to clipboard operation
volder copied to clipboard

Add Json function and its unit test

Open hariswb opened this issue 3 years ago • 7 comments

Here is my first PR. The test might not be exhaustive but I think it's good for the start.

hariswb avatar Feb 22 '22 16:02 hariswb

Codecov Report

Merging #92 (6af8e55) into main (419f932) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #92   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           67        68    +1     
  Lines          764       769    +5     
  Branches       338       338           
=========================================
+ Hits           764       769    +5     
Impacted Files Coverage Δ
src/lib/volder-types/json.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 419f932...6af8e55. Read the comment docs.

codecov[bot] avatar Feb 22 '22 16:02 codecov[bot]

thank you. it will be merge in the next version

alguerocode avatar Feb 23 '22 10:02 alguerocode

sorry you are forget the to Json function import in index.js

alguerocode avatar Feb 23 '22 15:02 alguerocode

my bad. i'll add that too

hariswb avatar Feb 23 '22 15:02 hariswb

@alguerocode I've just added the function in the index.js

hariswb avatar Mar 01 '22 10:03 hariswb

@alguerocode I've just added the function in the index.js

your are doing well bro

i will add in contributers section soon

I have a devSupporters team in discord, if you want join click in discord badge in readme.md file, there we will discuss the next version of volder 3.0.0

note: first send a message to know you. you will find me as the same name alguerocode thank you

alguerocode avatar Mar 02 '22 02:03 alguerocode

thanks. i'll check out the discord

hariswb avatar Mar 02 '22 14:03 hariswb