droidcam icon indicating copy to clipboard operation
droidcam copied to clipboard

fix some issues

Open skbeh opened this issue 3 years ago • 1 comments

  1. Automatically detect libturbojpeg linking arguments.
  2. Fixed a data race with a_running and v_running when exiting.
  3. Automatically try next v4l2 dev when failing to set pixel format.
  4. Not reset gtk widgets when gtk main loop has stopped.
  5. Wait until battery level info is received (currently always 1s), because level info is actually sent later so mostly recv returns before the client sends.

skbeh avatar Oct 05 '22 08:10 skbeh

Most of these changes looks fine, however

  • usbmuxd-2.0 is not available on Ubuntu (from what I can see), its still just libusbmuxd.
  • libjpeg-turbo is statically linked on purpose, this has been the most consistent way to get the correct library across distros.
  • The battery parsing code doesn't seem to be any better with the given changes, its very hacky to begin with and I would not change it unless making significant changes on how its accomplished in the first place.

aramg avatar Mar 08 '23 23:03 aramg