puppet-os-hardening icon indicating copy to clipboard operation
puppet-os-hardening copied to clipboard

Bc satisfy lynis

Open brentclark opened this issue 3 years ago • 2 comments

Good day

I would like to submit a PR to disable some network protocols that typically are not used. This will too satisfy Lynis.

Regards Brent

brentclark avatar Jan 21 '22 19:01 brentclark

Codecov Report

Merging #294 (5b247b6) into master (690b5c9) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 5b247b6 differs from pull request most recent head 89dfe22. Consider uploading reports for the commit 89dfe22 to get more accurate results Impacted file tree graph

@@           Coverage Diff           @@
##           master     #294   +/-   ##
=======================================
  Coverage   40.81%   40.81%           
=======================================
  Files           4        4           
  Lines          49       49           
=======================================
  Hits           20       20           
  Misses         29       29           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 690b5c9...89dfe22. Read the comment docs.

codecov-commenter avatar Jan 21 '22 19:01 codecov-commenter

@brentclark Thanks for your PR! In general this looks good to me, but you should also make it configurable like $disable_filesystems (in init.pp plus documentation in README.md)

mcgege avatar Jan 27 '22 15:01 mcgege