linux-patch-baseline
linux-patch-baseline copied to clipboard
dev-sec
Move the control examples out of the resource pack
When this is used as a resource pack but the controls are not used it populates the output data with extra data. I think we should split this into a proper resource pack and then an example repo that depends on the resource pack and put the control tests in the example.
hi @aaronlippold thank you for your feedback. I am not sure I fully understand your concern since the resources can already be used as a resource pack. The controls are optional. Can you provide an example?
The issue is when you depend on the profile it still outputs data on the CLI and json about those controls even if I didn't run them. It confuses end users. They assume something is broken because the control ids are listed but have no data which is true. I'll show you in person. It might me easier. Still in travel.
On Sun, May 19, 2019, 2:42 AM Christoph Hartmann [email protected] wrote:
hi @aaronlippold https://github.com/aaronlippold thank you for your feedback. I am not sure I fully understand your concern since the resources can already be used as a resource pack. The controls are optional. Can you provide an example?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/dev-sec/linux-patch-baseline/issues/24?email_source=notifications&email_token=AALK42GLPV7CF5FYNC7TKBTPWEOINA5CNFSM4HN3EXP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVW6OWQ#issuecomment-493741914, or mute the thread https://github.com/notifications/unsubscribe-auth/AALK42ESELAYI6CPR2JXDA3PWEOINANCNFSM4HN3EXPQ .
@aaronlippold It would be great to have a screenshot and the version that you're using. I cannot see any direct output except for stderr within the resources.
No problem I will work that. Running around conf at the moment.
Aaron
Aaron Lippold
260-255-4779
twitter/aim/yahoo,etc. 'aaronlippold'
On Mon, May 20, 2019 at 12:44 AM Christoph Hartmann < [email protected]> wrote:
@aaronlippold https://github.com/aaronlippold It would be great to have a screenshot and the version that you're using. I cannot see any direct output except for stderr within the resources.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/dev-sec/linux-patch-baseline/issues/24?email_source=notifications&email_token=AALK42AIMITRALQGKRHINI3PWJJEJA5CNFSM4HN3EXP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVX6YJI#issuecomment-493874213, or mute the thread https://github.com/notifications/unsubscribe-auth/AALK42ANHBKNFSSWNOR45MDPWJJEJANCNFSM4HN3EXPQ .