ansible-collection-hardening icon indicating copy to clipboard operation
ansible-collection-hardening copied to clipboard

Published 20 hours ago • verified publisher icon dev-sec

fix: verify group exists

Open hackardoX opened this issue 6 months ago • 3 comments

The purpose of this PR is to fix an issue that is there when try to change the ownership of file systems. Currently, depending on different versions of Ubuntu, the syslog group can or cannot be there. Therefore, I added a check and eventually create the missing groups. This is linked to #614 and #746.

I am not sure that my approach is the correct one. Maybe, if a group does not exists, we should just use 'root' instead. What is your advice?

hackardoX avatar Jun 02 '25 05:06 hackardoX

LGTM. Can you please fix the linting-errors?

rndmh3ro avatar Jun 02 '25 06:06 rndmh3ro

@rndmh3ro can you merge this PR?

hackardoX avatar Jun 02 '25 09:06 hackardoX

Anyone could merge this PR? (@rndmh3ro)

hackardoX avatar Jun 06 '25 07:06 hackardoX