teams-phone-fix
teams-phone-fix copied to clipboard
dev-rke
Feature Request: other url option
I think this little add-on is brilliant. However if you have to use the "gov" side of Teams, this addon does not work (obviously) because the url is different. Could an option, or wildcard, be added for https://gov.teams.microsoft.us/?
Thank you, glad to hear this. :-)
Unfortunately i am unable to test against this url, as i don't have an account for the governance environment. Please feel free to provide me a working pull request, which is well tested. It should be the url you mentioned, i just found it in the official endpoint documentation: https://docs.microsoft.com/en-us/microsoft-365/enterprise/microsoft-365-u-s-government-gcc-high-endpoints?view=o365-worldwide#skype-for-business-online-and-microsoft-teams
Cool! I'll have to get on the Firefox nightly channel again since they locked us out of the plugins without a valid signature (I'll gripe later). But that is no big deal. I should actually have some time for this in the coming days.
Sorry for my late reply, i was a bit busy. I reviewed your pull request, it looks ok so far, but i would like to eliminate the wildcards.
I assumed you mean the wildcards in the tab-reload function. You are right. I guess I was a little carried away with the match pattern (https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Match_patterns).
It makes sense that it should only reload the target pages that we are adjusting the user agent for. I update accordingly.