devprotocol.xyz icon indicating copy to clipboard operation
devprotocol.xyz copied to clipboard

[FEATURE] Use the prettier plugin

Open vinzvinci opened this issue 3 years ago • 16 comments

Detailed description

Aggre asked this before to add Prettier plugin to automatically format the code

Context

CC @krishguptadev

Possible implementation

https://github.com/snowpackjs/prettier-plugin-astro

Additional information

image

Code of Conduct

  • [X] I agree to follow this project's Code of Conduct

vinzvinci avatar Nov 01 '21 00:11 vinzvinci

Buil code should not be formatted for performance reasons, I could add it to the src if you like 🙂

gptkrsh avatar Nov 01 '21 02:11 gptkrsh

Okay if it will affect the performance @krishguptadev, let's not add it.

vinzvinci avatar Nov 01 '21 02:11 vinzvinci

So add it to the source or not?

gptkrsh avatar Nov 01 '21 02:11 gptkrsh

If this was added to the source, it won't affect much right?

vinzvinci avatar Nov 01 '21 02:11 vinzvinci

If this was added to the source, it won't affect much right?

Would enforce a code style, that's it

gptkrsh avatar Nov 01 '21 02:11 gptkrsh

Okay, you can add it.

On Mon, 1 Nov 2021 at 10:57, Krish Gupta @.***> wrote:

If this was added to the source, it won't affect much right?

Would enforce a code style, that's it

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/web3community/devprotocol.xyz/issues/90#issuecomment-955882431, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARNWCWAO2KUU6HZPFWXXB7LUJX6X7ANCNFSM5HC5DUWQ .

vinzvinci avatar Nov 01 '21 02:11 vinzvinci

The Plugin is WIP, so we need to wait a while before it is prod released.

gptkrsh avatar Nov 01 '21 03:11 gptkrsh

Okeh sure 🚀

vinzvinci avatar Nov 01 '21 03:11 vinzvinci

Stale issue message

github-actions[bot] avatar Jan 01 '22 02:01 github-actions[bot]

Stale issue message

github-actions[bot] avatar Mar 11 '22 02:03 github-actions[bot]

Stale issue message

github-actions[bot] avatar May 14 '22 03:05 github-actions[bot]

Stale issue message

github-actions[bot] avatar Jul 22 '22 03:07 github-actions[bot]

HI, the plugin is working like a charm now: https://github.com/withastro/prettier-plugin-astro

mkubdev avatar Jul 22 '22 09:07 mkubdev

Stale issue message

github-actions[bot] avatar Sep 21 '22 04:09 github-actions[bot]

I've opened a PR so that this issue is finally closed

gptkrsh avatar Oct 01 '22 08:10 gptkrsh

Stale issue message

github-actions[bot] avatar Dec 01 '22 02:12 github-actions[bot]

Stale issue message

github-actions[bot] avatar Feb 08 '23 02:02 github-actions[bot]

We might want to upgrade to Astrov2 before this gets implemented just saying though

gptkrsh avatar Feb 08 '23 05:02 gptkrsh

Stale issue message

github-actions[bot] avatar Apr 11 '23 02:04 github-actions[bot]