autocmake icon indicating copy to clipboard operation
autocmake copied to clipboard

Setup script should check return code of configure step

Open bast opened this issue 7 years ago • 2 comments

Instead of doing this: https://github.com/coderefinery/autocmake/blob/master/autocmake/configure.py#L113-L118 which is brittle.

bast avatar Dec 07 '17 13:12 bast

Hi Rado,

def save_setup_command(argv, build_path)

is very useful function, because ordinary software users sometimes forget what exact form of setup command did they use.

For example, in DIRAC "./setup --mpi --fc=mpif90 --cc=mpicc --cxx=mpiCC --int64 --extra-fc-flags=-xHost --extra-cc-flags=-xHost --extra-cxx-flags=-xHost build_openmpi_intelmkl_i8_xh"

The setup_command file is missing '' . Would be good to add apostrophe.

miroi avatar Jan 08 '18 13:01 miroi

I think your suggestion is unrelated to the topic of this issue. Can you please open a new issue? Also in your issue please show what the command prints out now and what you would like to print instead. Thank you.

bast avatar Jan 09 '18 08:01 bast