Algorithms icon indicating copy to clipboard operation
Algorithms copied to clipboard

Implement Miller-Rabin Method in Primality Test Algorithms

Open adithyaakrishna opened this issue 4 years ago • 10 comments

Implement Miller-Rabin Method in Primality Test Algorithms in a language of your choice.

Please read the contributing guidelines in CONTRIBUTING.md

Languages claimed/implemented:

  • [x] C++ (by @arnav-roy)
  • [x] Java (by @96Octavian)
  • [x] Python (by @96Octavian)
  • [x] C# (by @96Octavian)

adithyaakrishna avatar Oct 02 '20 20:10 adithyaakrishna

@karthikshetty03 I don't have the permission to assign you, but you can work on this issue and create a commit in your fork and once @deutranium assigns you, you can immediately create a PR :)

adithyaakrishna avatar Oct 02 '20 21:10 adithyaakrishna

@adithyaakrishna thanks for your helpful comments!!

@karthikshetty03 Github requires you to comment on the issue first for me to be able to add you as an assignee. Please comment here with the language you would like to work with.

deutranium avatar Oct 02 '20 21:10 deutranium

If there's no assignee, I can provide a Python implementation and maybe translate it to C# (and probably Java too)

96Octavian avatar Oct 03 '20 17:10 96Octavian

@96Octavian sure. Should I assign all the three (C, Python, C#) to you?

deutranium avatar Oct 03 '20 17:10 deutranium

Yes please. I can do Python, C# and Java (I don't know a thing about C++ though, can't promise)

96Octavian avatar Oct 03 '20 18:10 96Octavian

@96Octavian sure I'll assign these 3 to you. Happy coding!!

deutranium avatar Oct 03 '20 18:10 deutranium

I want to contribute in C++

arnav-roy avatar Oct 03 '20 18:10 arnav-roy

@arnav-roy sure assigned it to you

deutranium avatar Oct 03 '20 19:10 deutranium

Should camel case be followed even in languages where it is not standard naming convention?

96Octavian avatar Oct 05 '20 08:10 96Octavian

@96Octavian no you can follow for example snake case in python. That rule was added to ensure that there is a uniformity in code style

deutranium avatar Oct 05 '20 12:10 deutranium