Algorithms icon indicating copy to clipboard operation
Algorithms copied to clipboard

Implement Kadane's algorithm in Java

Open akshaygidwani404 opened this issue 3 years ago • 12 comments

Implement Kadane's algorithm in Java

Please read the contributing guidelines in CONTRIBUTING.md

Languages claimed/implemented:

  • [x] C
  • [x] C++
  • [x] Java
  • [x] Python
  • [x] Javascript
  • [ ] Any other language

akshaygidwani404 avatar Oct 08 '21 07:10 akshaygidwani404

@akshaygidwani404 I want to contribute to this problem.

DarkSoul26 avatar Oct 08 '21 07:10 DarkSoul26

Hey @deutranium! I have implemented Kadane's algorithm in Java following Contribution Guidelines and reference to issue #221 and made a PR #222 for the same. Kindly review it and merge it. Thanks!

akshaygidwani404 avatar Oct 08 '21 08:10 akshaygidwani404

Hello, I would want to contribute to this repo. I can implement Kadane's algorithm in C language. Can you assign it to me?

AdityaVSM avatar Oct 08 '21 16:10 AdityaVSM

@AdityaVSM Hi! Yes, you can work on it. @DarkSoul26 Hi! Yes, you can do it as long as it's in a language other than C/C++/Java/Python as the code in these languages is already done/claimed.

@akshaygidwani404 I have commented on the PR, please have a look.

codelixir avatar Oct 11 '21 04:10 codelixir

Thank you @codelixir for your feedback. I have fixed the issue. PR #222. Kindly review it. Thanks!

akshaygidwani404 avatar Oct 11 '21 11:10 akshaygidwani404

Closed #222 for java. Thanks @akshaygidwani404!

codelixir avatar Oct 12 '21 05:10 codelixir

Hello @codelixir , @akshaygidwani404 can you check PR #230

AdityaVSM avatar Oct 16 '21 06:10 AdityaVSM

Closing for C. Thanks, @AdityaVSM!

codelixir avatar Oct 16 '21 19:10 codelixir

hey @codelixir please assign me the issue to solve it in javascript

skywalker2207 avatar Oct 13 '22 17:10 skywalker2207

@codelixir Hii , I can implement Kadane's algorithm in C++ language. Can you please assign me

1-Sanchit-1 avatar Oct 15 '22 03:10 1-Sanchit-1

@1-Sanchit-1 it is already implemented in C++, you can do it in any language not taken up yet

codelixir avatar Oct 15 '22 04:10 codelixir

Merged #261 for JS

codelixir avatar Oct 26 '22 13:10 codelixir