Daniel Herman

Results 63 comments of Daniel Herman

@thatlittleboy Okay so I read the other issue and all the points are valid. My habit is that when I join new project that wasn't maintained properly using black and...

@ReinierKoops I didn't know there is subclass for that, I will try it

Maybe a cleaner design would be to have one class `ShapRFECV` that would not depend on the type of `clf`. Or then have children class for `LGBMClassifier`. Having `ShapRFECV` for...

@ReinierKoops Could you have a look at this please?

Thanks. Regarding breaking change, there could be an optional argument in `ShapRFECV` that would switch between new and old behaviour. Alternatively, there could be a different part or different name...

> If you want to take a stab at it, I’ll review it and merge it when done (if made backwards compatible/deprecation warning) Sure, this could be a fun, plus...

@ReinierKoops Meanwhile I decided to persuade career opportunity in SImilarweb instead of Home Credit, so there is no need for this particular PR at my work. I might still use...

@ztjhz Could you please have a look at this one? It should be an easy fix and as of now it is impossible to use the newest Azure API endpoint.

maybe something like this? ```typescript const url = new URL(endpoint); // Gets all query string value const params = new URLSearchParams(url.search); // Checking if api-version exist if (params.has('api-version')) { //...

I believe I know how to fix it, I will open PR