dethrace icon indicating copy to clipboard operation
dethrace copied to clipboard
verified publisher icon dethrace-labs

src/DETHRACE/pc-dos/dossys.c is incomplete

Open madebr opened this issue 8 months ago • 1 comments

The 3dfx patch unconditionally uses src/DETHRACE/pc-dos/dossys.c and disables src/DETHRACE/pc-win95/win95sys.c completely: https://github.com/dethrace-labs/dethrace/blob/2e31fc6956a5a10598d6afe023af8bbedc3278ba/src/DETHRACE/pc-win95/win95sys.c#L1

However, multiple functions are more advanced in the win95 implementation then in the dos implementation, e.g. PDShutdownSystem. Also, certain functions are slightly incompatible: e.g. PDLockRealBackScreen(int) vs PDLockRealBackScreen(void)

madebr avatar Apr 06 '25 15:04 madebr

My proposal is to introduce a new pc-all implementation that is independent of all platforms and forwards platform peculiarities to the platform harness.

I'd keep pc-dos and pc-win95 around if we ever want to create an (semi-) accurate DOS or WIN95 implementation.

madebr avatar Apr 06 '25 15:04 madebr