Gonçalo Valério

Results 25 comments of Gonçalo Valério

Could this error be due to some protocol changes in recent firmware updates?

Any news about the current progress and status? Looking at the current issues and pull requests, there are relevant security problems that need to be solved. Some of them already...

@lopesrb It took a while :), but here it is. Can you review again?

Thanks. Well it seems I still can't merge, this repository settings must be messed up. Ping @pjaneiro .

It doesn't seem that there will be much more activity in this PR. The feature looks good and the suggested improvements can be added later.

I suspect this issue might be related to https://github.com/lnbits/bolt11/issues/40. Since on my tests, `invoice.expiry` is always `None` here: ```python def get_bolt11_expiry(invoice: Bolt11) -> datetime.datetime: if invoice.expiry: # x (6): data_length...

Yes, you are right. The current name isn't a great fit, it's just the name that quickly came to my mind when I started the experiment. Not sure if renaming...

It would be a great feature to have indeed. However I'm not sure if it is possible (at least with the available X API and without the "access watcher" app...

Hello, can you provide a few more details, so I can try to reproduce the problem? Things that would be useful: * Node.js version you are using * Which version...