Thibault Deutsch
Thibault Deutsch
@bai any thought?
TODO: - [ ] New unit test - [ ] Documentation But open to feedback about the API itself, if someone think we should do this differently or not at...
Ready for review but not for merging, I want to add to try to add a test for this before (which is a bit painful because it needs hadoop hdfs...
Open to contribution
We currently don't implement this API. Someone would need to add support for it in the admin client. The proto RPC to implement would be: https://github.com/tsuna/gohbase/blob/master/pb/Master.proto#L558-L559
The flamegraph is [attached to the jira ticket](https://issues.apache.org/jira/secure/attachment/13067885/Screenshot%202024-04-05%20at%2000.27.11.png).
Hm I need to fix some of the tests. The patch was for HBase 2.5.10, the actual version we run. Didn't think of making sure it was enough for HBase...
> Oops. Yeah that sounds bad. Thank you for fixing it. What is your configured sampling rate? We actually don’t have tracing enabled. But spans will still be created even...
> So the problem is allocation? > > What if we just store the region name some where so we do not need to construct it every time? That’s another...