TypeChain icon indicating copy to clipboard operation
TypeChain copied to clipboard

ethers-v6: Please consider implementing `Result` methods like `toArray()` and `toObject()`

Open shirotech opened this issue 2 years ago • 3 comments
trafficstars

https://github.com/ethers-io/ethers.js/blob/main/src.ts/abi/coders/abstract-coder.ts#L138

https://github.com/ethers-io/ethers.js/blob/main/src.ts/abi/coders/abstract-coder.ts#L153

Both methods are invaluable to most common use-cases. Thank you.

shirotech avatar Mar 23 '23 17:03 shirotech

Have made a PR for this: #818

shirotech avatar Mar 23 '23 18:03 shirotech

Is there any update here?

emretepedev avatar Nov 08 '23 02:11 emretepedev

I'm not really sure, it's been so long, @krzkaczor please let me know anything you need on this before it can be merged? Thank you.

shirotech avatar Nov 08 '23 02:11 shirotech

Is there any update here? I got a lot of type errors because of this.

handanyolak avatar Mar 03 '24 06:03 handanyolak

Same issue here.

emretepedev avatar Mar 03 '24 23:03 emretepedev

Seems this project is deprecated, maintainer is not responsive and so I have moved onto viem as mentioned in the README.md, I will not spend any more time on this. Feel free to fork and open up another PR (Good luck on getting it merged). Cheers.

shirotech avatar Mar 05 '24 04:03 shirotech