TypeChain icon indicating copy to clipboard operation
TypeChain copied to clipboard

Unused type in new release

Open yorhodes opened this issue 2 years ago • 4 comments

'PromiseOrValue' is declared but never used.

with "@typechain/ethers-v5": "10.1.0" / "typechain": "8.1.0"

yorhodes avatar Jun 13 '22 15:06 yorhodes

Is it coming from eslint or ts? if it's eslint we add the artifacts to eslintignore

jmrossy avatar Jun 13 '22 16:06 jmrossy

typescript I don't think noUnusedLocals: false should be required

yorhodes avatar Jun 13 '22 16:06 yorhodes

I think this might also be related to the issue I have been having! #686

sbahman avatar Jun 20 '22 23:06 sbahman

This is also breaking our build, and there doesn't seem to be an easy automated fix.

I was able to reproduce this with @typechain/[email protected] and [email protected], but downgrading to @typechain/[email protected] and keeping [email protected] seemed to work.

apottere avatar Jul 19 '22 21:07 apottere

Published a fix in #776 that's fairly simple. Changing the tsconfig for a project for us for this codegen issue isn't really a great option as well, especially since the recommendation from the typechain team is to include typechain in the build step for your project.

iainnash avatar Sep 27 '22 19:09 iainnash