determined icon indicating copy to clipboard operation
determined copied to clipboard

chore: re-split code editor

Open ashtonG opened this issue 1 year ago • 2 comments
trafficstars

Ticket

none

Description

This fixes an issue where the code editor was being included in the main app bundle. While you can indicate that a component is meant to be split with React.lazy, if any code elsewhere imports the code statically the code is unsplit. We wrap the code split component and ban other imports using eslint to prevent this from regressing.

Test Plan

Frontend bundle size should be reduced. visiting places where the code editor is visible should show a spinner while the code editor is loading

Checklist

  • [x] Changes have been manually QA'd
  • [x] New features have been approved by the corresponding PM
  • [x] User-facing API changes have the "User-facing API Change" label
  • [x] Release notes have been added as a separate file under docs/release-notes/ See Release Note for details.
  • [x] Licenses have been included for new code which was copied and/or modified from any external code

ashtonG avatar Sep 06 '24 17:09 ashtonG

Deploy Preview for determined-ui ready!

Name Link
Latest commit 72148da0261581a1c2a7e01697a3300c287d2fbc
Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66db3790eff2ad0008f8651e
Deploy Preview https://deploy-preview-9899--determined-ui.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Sep 06 '24 17:09 netlify[bot]

Codecov Report

Attention: Patch coverage is 74.46809% with 12 lines in your changes missing coverage. Please review.

Project coverage is 50.58%. Comparing base (8c83d31) to head (72148da). Report is 212 commits behind head on main.

Files with missing lines Patch % Lines
webui/react/src/components/Markdown.tsx 0.00% 8 Missing :warning:
...ui/react/src/pages/Templates/TemplateViewModal.tsx 0.00% 2 Missing :warning:
...ebui/react/src/components/WorkspaceCreateModal.tsx 0.00% 1 Missing :warning:
.../react/src/pages/Templates/TemplateCreateModal.tsx 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9899      +/-   ##
==========================================
- Coverage   54.70%   50.58%   -4.13%     
==========================================
  Files        1262      940     -322     
  Lines      156760   127375   -29385     
  Branches     3597     3595       -2     
==========================================
- Hits        85762    64430   -21332     
+ Misses      70867    62814    -8053     
  Partials      131      131              
Flag Coverage Δ
harness ?
web 54.43% <74.46%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
webui/react/src/components/CodeEditor.tsx 100.00% <100.00%> (ø)
...i/react/src/components/ExperimentContinueModal.tsx 63.31% <100.00%> (-0.28%) :arrow_down:
...bui/react/src/components/ExperimentCreateModal.tsx 81.41% <100.00%> (-0.18%) :arrow_down:
webui/react/src/components/JupyterLabModal.tsx 84.58% <100.00%> (-0.04%) :arrow_down:
webui/react/src/components/Metadata.tsx 56.66% <100.00%> (-1.40%) :arrow_down:
webui/react/src/components/UserSettingsModal.tsx 19.62% <100.00%> (ø)
...c/pages/ExperimentDetails/ExperimentCodeViewer.tsx 88.53% <100.00%> (-0.08%) :arrow_down:
...ebui/react/src/components/WorkspaceCreateModal.tsx 0.00% <0.00%> (ø)
.../react/src/pages/Templates/TemplateCreateModal.tsx 0.00% <0.00%> (ø)
...ui/react/src/pages/Templates/TemplateViewModal.tsx 0.00% <0.00%> (ø)
... and 1 more

... and 323 files with indirect coverage changes

codecov[bot] avatar Sep 06 '24 17:09 codecov[bot]