determined icon indicating copy to clipboard operation
determined copied to clipboard

chore: create WorkloadType enum and Go config + constraints structs

Open amandavialva01 opened this issue 1 year ago • 2 comments

Ticket

CM-501

Description

This PR implements the following:

  • Define WorkloadType enum in Protobuf and create Go constants that map to and from the Protobuf enum.

  • Define Go Constraints struct that’s agnostic to workload type

  • Define Go ExperimentTaskConfigPolicy and NTSCTaskConfigPolicy structs that allows parsing configs and constraints at the API level for the respective workload type.

Test Plan

CI passes (automated testing).

Checklist

  • [ ] Changes have been manually QA'd
  • [ ] New features have been approved by the corresponding PM
  • [ ] User-facing API changes have the "User-facing API Change" label
  • [ ] Release notes have been added as a separate file under docs/release-notes/ See Release Note for details.
  • [ ] Licenses have been included for new code which was copied and/or modified from any external code

amandavialva01 avatar Aug 30 '24 17:08 amandavialva01

Deploy Preview for determined-ui canceled.

Name Link
Latest commit 879e03c3d5cdaf8d7a3d8fa395a3641e0a24f84b
Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66d88d26b20ebd0008e0b7d4

netlify[bot] avatar Aug 30 '24 17:08 netlify[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 54.75%. Comparing base (ee269c8) to head (879e03c). Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9885      +/-   ##
==========================================
- Coverage   54.75%   54.75%   -0.01%     
==========================================
  Files        1261     1262       +1     
  Lines      156333   156337       +4     
  Branches     3600     3598       -2     
==========================================
- Hits        85604    85603       -1     
- Misses      70598    70603       +5     
  Partials      131      131              
Flag Coverage Δ
backend 45.21% <100.00%> (-0.01%) :arrow_down:
harness 72.62% <ø> (ø)
web 54.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
master/pkg/model/task_config_policy.go 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

codecov[bot] avatar Aug 30 '24 17:08 codecov[bot]