determined
determined copied to clipboard
fix: Remove CSS rule for hiding the Form.Item error message
Ticket
Description
There's a bug where, when you try to submit a form with errors, the error feedback messages won't show bellow the form items.
This PR intends to fix that.
Test Plan
- Open a modal with a form.
- try submitting with an error (like not filling a required field)
- the message should appear bellow the form item.
Checklist
- [ ] Changes have been manually QA'd
- [ ] New features have been approved by the corresponding PM
- [ ] User-facing API changes have the "User-facing API Change" label
- [ ] Release notes have been added as a separate file under
docs/release-notes/See Release Note for details. - [ ] Licenses have been included for new code which was copied and/or modified from any external code
Deploy Preview for determined-ui ready!
| Name | Link |
|---|---|
| Latest commit | 56a71a01a31bc824c5734ea7219233d408c87e03 |
| Latest deploy log | https://app.netlify.com/sites/determined-ui/deploys/66ec9675013e540008833f37 |
| Deploy Preview | https://deploy-preview-9872--determined-ui.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 50.42%. Comparing base (
eb1b0de) to head (56a71a0). Report is 2 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #9872 +/- ##
==========================================
- Coverage 54.49% 50.42% -4.08%
==========================================
Files 1255 946 -309
Lines 156729 128135 -28594
Branches 3601 3600 -1
==========================================
- Hits 85413 64611 -20802
+ Misses 71183 63391 -7792
Partials 133 133
| Flag | Coverage Ξ | |
|---|---|---|
| harness | ? |
|
| web | 54.27% <ΓΈ> (ΓΈ) |
Flags with carried forward coverage won't be shown. Click here to find out more.