determined
determined copied to clipboard
determined-ai
chore: Remove model hub
Ticket
https://hpe-aiatscale.atlassian.net/browse/MD-461
Description
Remove model_hub library and subdirectory from determined
Test Plan
No testing required
Checklist
- [ ] Changes have been manually QA'd
- [ ] New features have been approved by the corresponding PM
- [ ] User-facing API changes have the "User-facing API Change" label
- [ ] Release notes have been added as a separate file under
docs/release-notes/See Release Note for details. - [ ] Licenses have been included for new code which was copied and/or modified from any external code
Deploy Preview for determined-ui canceled.
| Name | Link |
|---|---|
| Latest commit | 4e56b563fff73934bbbb7f0d8cb20b868a8cfadd |
| Latest deploy log | https://app.netlify.com/sites/determined-ui/deploys/66d0b02880a0690008d6e711 |
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 54.58%. Comparing base (
a1234a1) to head (4e56b56). Report is 25 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #9869 +/- ##
==========================================
- Coverage 54.66% 54.58% -0.09%
==========================================
Files 1261 1247 -14
Lines 156328 155531 -797
Branches 3584 3584
==========================================
- Hits 85463 84898 -565
+ Misses 70733 70501 -232
Partials 132 132
| Flag | Coverage Δ | |
|---|---|---|
| backend | 45.21% <ø> (-0.07%) |
:arrow_down: |
| harness | 72.78% <ø> (+0.16%) |
:arrow_up: |
| web | 54.30% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
@azhou-determined! Could you take a look at this too? I know you've done a ton of work on the harness side.
Failures all disappeared on retry, and are being looked into elsewhere as flaky. The failure that remains is the one with the ChromaDB version. But these e2e test runs aren't free, so I'm not going to rebase and re-run - I think we've established that this patch passes tests. Time to merge!
