determined icon indicating copy to clipboard operation
determined copied to clipboard

ci: restore "get project columns for runs table" to performance tests

Open mackrorysd opened this issue 1 year ago • 3 comments

Description

We missed this when we added the Locust tests. I'm guessing this was added to K6 recently. We're not testing this endpoint without parameters because of performance reasons, so it's important to at least be testing this variant.

Test Plan

I think there's an option to run this in CI - if not I'll run it locally to be sure. I will update this before merging either way.

Checklist

  • [ ] Changes have been manually QA'd
  • [ N/A ] New features have been approved by the corresponding PM
  • [ N/A ] User-facing API changes have the "User-facing API Change" label
  • [ N/A ] Release notes have been added as a separate file under docs/release-notes/ See Release Note for details.
  • [ N/A ] Licenses have been included for new code which was copied and/or modified from any external code

mackrorysd avatar Aug 12 '24 17:08 mackrorysd

Deploy Preview for determined-ui canceled.

Name Link
Latest commit d2d711afbce45fba06fae1f8753539bcf01c8155
Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66e08c770a5d290008cdae4d

netlify[bot] avatar Aug 12 '24 17:08 netlify[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 54.61%. Comparing base (8fb9f6b) to head (d2d711a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9811      +/-   ##
==========================================
- Coverage   59.24%   54.61%   -4.63%     
==========================================
  Files         750      722      -28     
  Lines      104341   102506    -1835     
  Branches     3597     3597              
==========================================
- Hits        61812    55986    -5826     
- Misses      42398    46389    +3991     
  Partials      131      131              
Flag Coverage Δ
backend 43.80% <ø> (ø)
harness 55.96% <ø> (-16.79%) :arrow_down:
web 54.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 154 files with indirect coverage changes

codecov[bot] avatar Aug 12 '24 17:08 codecov[bot]

Hey @mackrorysd , I was going through my inbox and came across this change. Just a friendly reminder that this h as not yet be merged.

highvelcty avatar Sep 09 '24 22:09 highvelcty