determined icon indicating copy to clipboard operation
determined copied to clipboard

test: collect det job ci logs only in case of failure

Open hamidzr opened this issue 1 year ago • 2 comments

Ticket

Description

also ensures the steps run when the tests fail

Test Plan

make the tests fail to see the logs get collected https://github.com/determined-ai/determined/pull/9537/commits/469c6d68893a8abab28cc1301b460b1f0a5be01a

Checklist

  • [ ] Changes have been manually QA'd
  • [ ] New features have been approved by the corresponding PM
  • [ ] User-facing API changes have the "User-facing API Change" label
  • [ ] Release notes have been added as a separate file under docs/release-notes/ See Release Note for details.
  • [ ] Licenses have been included for new code which was copied and/or modified from any external code

hamidzr avatar Jun 18 '24 15:06 hamidzr

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 52.88%. Comparing base (3f7cad6) to head (c5bb05c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9537   +/-   ##
=======================================
  Coverage   52.88%   52.88%           
=======================================
  Files        1255     1255           
  Lines      153086   153086           
  Branches     3230     3230           
=======================================
+ Hits        80958    80960    +2     
+ Misses      71977    71975    -2     
  Partials      151      151           
Flag Coverage Δ
backend 44.00% <ø> (+<0.01%) :arrow_up:
harness 72.76% <ø> (ø)
web 51.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

codecov[bot] avatar Jun 18 '24 15:06 codecov[bot]

Deploy Preview for determined-ui ready!

Name Link
Latest commit c5bb05cddd9bb3fccbb586bb2143a44c48429c82
Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/668c32632cb1ba00084fa287
Deploy Preview https://deploy-preview-9537--determined-ui.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jun 18 '24 15:06 netlify[bot]