determined icon indicating copy to clipboard operation
determined copied to clipboard

chore: set cli pwd warning go to stderr

Open hamidzr opened this issue 1 year ago • 2 comments

Ticket

Description

we'd probably want a shared path for all cli warnings. we have deprecation warnings and probably other warning classes as well

or maybe use https://docs.python.org/3/library/exceptions.html#UserWarning ?

Test Plan

det u logout; det e ls > /dev/null

Checklist

  • [ ] Changes have been manually QA'd
  • [ ] New features have been approved by the corresponding PM
  • [ ] User-facing API changes have the "User-facing API Change" label
  • [ ] Release notes have been added as a separate file under docs/release-notes/ See Release Note for details.
  • [ ] Licenses have been included for new code which was copied and/or modified from any external code

hamidzr avatar Jun 18 '24 14:06 hamidzr

Deploy Preview for determined-ui canceled.

Name Link
Latest commit 4155b1f700ed8ee80a6e0c1b350987a35ba397e8
Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/668c32874af1ec0008392fa9

netlify[bot] avatar Jun 18 '24 14:06 netlify[bot]

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 52.88%. Comparing base (3f7cad6) to head (4155b1f). Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9536   +/-   ##
=======================================
  Coverage   52.88%   52.88%           
=======================================
  Files        1255     1255           
  Lines      153086   153089    +3     
  Branches     3230     3230           
=======================================
+ Hits        80958    80967    +9     
+ Misses      71977    71971    -6     
  Partials      151      151           
Flag Coverage Δ
backend 44.00% <ø> (+0.01%) :arrow_up:
harness 72.77% <80.00%> (+<0.01%) :arrow_up:
web 51.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
harness/determined/common/api/authentication.py 87.50% <100.00%> (+0.12%) :arrow_up:
harness/determined/cli/user.py 53.23% <0.00%> (ø)

... and 3 files with indirect coverage changes

codecov[bot] avatar Jun 18 '24 14:06 codecov[bot]