determined
determined copied to clipboard
chore: make pod spec choice consistent
Ticket
Description
We choose what pod spec to apply to a resource pool/experiment in two places, and two different ways. Let's try to harmonize this choice such that we will (more) consistently choose the same pod spec to define a pool and for experiments requested to run on it.
For example, if you're running a CPU cluster, you would intuitively want to define a cpuPodSpec for pods that experiments run on, and pods included in resource pools. Right now, GetAgents chooses which pod spec to use based on which one is defined AND device type (CPU vs CUDA). However, MergeExpConf chooses which pod spec to use based on how many slots an experiment wants (<=1 slot defaults to GPU pod spec). This makes it impossible to run experiments requiring more than 1 slot on a CPU cluster with a CPU podSpec defined.
Right now I'm merging this into my node selectors feature branch, but I can merge this into main after some rebasing. I will wait to merge https://github.com/determined-ai/determined/pull/9428 until this PR is merged.
Test Plan
Pass CircleCI + i'll write a test (in progress)
Checklist
- [ ] Changes have been manually QA'd
- [ ] User-facing API changes need the "User-facing API Change" label.
- [ ] Release notes should be added as a separate file under
docs/release-notes/. See Release Note for details. - [ ] Licenses should be included for new code which was copied and/or modified from any external code.
Deploy Preview for determined-ui ready!
| Name | Link |
|---|---|
| Latest commit | 72807652de16db2a738309c583ccd9d699a7e2cc |
| Latest deploy log | https://app.netlify.com/sites/determined-ui/deploys/66704551ac39b800080ecac5 |
| Deploy Preview | https://deploy-preview-9531--determined-ui.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 51.36%. Comparing base (
01c9b1d) to head (829c3f3).
Additional details and impacted files
@@ Coverage Diff @@
## carolinac/rm-255 #9531 +/- ##
====================================================
+ Coverage 49.30% 51.36% +2.06%
====================================================
Files 1242 750 -492
Lines 161471 112195 -49276
Branches 2868 2867 -1
====================================================
- Hits 79606 57631 -21975
+ Misses 81693 54392 -27301
Partials 172 172
| Flag | Coverage Δ | |
|---|---|---|
| backend | 34.25% <ø> (-9.70%) |
:arrow_down: |
| harness | 63.61% <ø> (-0.20%) |
:arrow_down: |
| web | 44.87% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
@carolinaecalderon what's up with this pr? just found it randomly.