determined icon indicating copy to clipboard operation
determined copied to clipboard

feat: timeout change and package dedupe [ET-243]

Open JComins000 opened this issue 10 months ago β€’ 3 comments

Ticket

ET-243

Description

change default timeout for toast notifications and take the "deflake" out of the testcase now that the notifications last longer

Test Plan

There's a test in auth.spec that supports this change a little. I'd recommend running that test.

manual test steps:

  • npm i
  • try to sign in with bad creds
  • wait 8 seconds for the toast to disappear

Checklist

  • [ ] Changes have been manually QA'd
  • [ ] User-facing API changes need the "User-facing API Change" label.
  • [ ] Release notes should be added as a separate file under docs/release-notes/. See Release Note for details.
  • [ ] Licenses should be included for new code which was copied and/or modified from any external code.

JComins000 avatar Apr 29 '24 22:04 JComins000

Deploy Preview for determined-ui ready!

Name Link
Latest commit b819fceafe17a815caed3ce1e132a24cfeae61ff
Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66302dbdebbdb20008ce9ea6
Deploy Preview https://deploy-preview-9265--determined-ui.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Apr 29 '24 22:04 netlify[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 37.94%. Comparing base (4d87127) to head (b819fce). Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9265      +/-   ##
==========================================
- Coverage   44.64%   37.94%   -6.71%     
==========================================
  Files        1273      949     -324     
  Lines      155827   116100   -39727     
  Branches     2439     2439              
==========================================
- Hits        69570    44052   -25518     
+ Misses      86018    71809   -14209     
  Partials      239      239              
Flag Coverage Ξ”
harness ?
web 35.04% <ΓΈ> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 324 files with indirect coverage changes

codecov[bot] avatar Apr 29 '24 22:04 codecov[bot]

please add test plan

keita-determined avatar Apr 29 '24 23:04 keita-determined