determined icon indicating copy to clipboard operation
determined copied to clipboard

feat: add custom key to projects table, backfilling based on current project name, and API support

Open corban-beaird opened this issue 10 months ago • 2 comments

Ticket

ET-97 ET-101 ET-102 ET-164

Description

Introduce custom project key (similar to JIRA's project key), to be able to refer to projects. This adds the column to the DB & backfills existing projects based on their existing project name.

This also includes allowing the key to be specified in the CreateProject endpoint (PostProject).

Test Plan

  • Automated Integration Testing

Checklist

  • [ ] Changes have been manually QA'd
  • [ ] User-facing API changes need the "User-facing API Change" label.
  • [ ] Release notes should be added as a separate file under docs/release-notes/. See Release Note for details.
  • [ ] Licenses should be included for new code which was copied and/or modified from any external code.

Commentary

Work will need to be done to allow updating project keys of existing projects (that is being handled in ET-98). This will likely include updating the logic for how we determine uniqueness, since the requirement will need to ensure no past project keys had been in use.

corban-beaird avatar Apr 09 '24 17:04 corban-beaird

Deploy Preview for determined-ui canceled.

Name Link
Latest commit 47f19fc4213ca512e683ce516e6e7994efcba97b
Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66672f6bfc0e8b0008647028

netlify[bot] avatar Apr 09 '24 17:04 netlify[bot]

Codecov Report

Attention: Patch coverage is 53.95480% with 163 lines in your changes missing coverage. Please review.

Project coverage is 48.99%. Comparing base (96c061b) to head (47f19fc). Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9134      +/-   ##
==========================================
+ Coverage   48.96%   48.99%   +0.02%     
==========================================
  Files        1234     1235       +1     
  Lines      159823   160128     +305     
  Branches     2781     2780       -1     
==========================================
+ Hits        78264    78454     +190     
- Misses      81384    81499     +115     
  Partials      175      175              
Flag Coverage Δ
backend 43.82% <56.27%> (+0.11%) :arrow_up:
harness 63.96% <37.20%> (-0.03%) :arrow_down:
web 44.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
harness/determined/cli/workspace.py 21.23% <100.00%> (ø)
harness/determined/common/streams/wire.py 58.58% <100.00%> (+0.42%) :arrow_up:
harness/tests/common/streams/test_client.py 89.03% <ø> (ø)
master/internal/db/postgres.go 51.46% <ø> (ø)
master/internal/stream/projects.go 77.01% <ø> (ø)
master/test/streamdata/stream_data.go 100.00% <100.00%> (ø)
master/internal/project/authz_basic_impl.go 17.30% <75.00%> (+15.22%) :arrow_up:
master/pkg/model/project.go 0.00% <0.00%> (ø)
harness/determined/cli/project.py 17.64% <0.00%> (ø)
master/pkg/random/string.go 83.33% <83.33%> (ø)
... and 6 more

... and 5 files with indirect coverage changes

codecov[bot] avatar Apr 09 '24 17:04 codecov[bot]