determined
determined copied to clipboard
fix: prevent selection from appearing out of place in infinite scroll
Description
This fixes an issue where the user selection was placed in the wrong place without the glasbey colors applied
Test Plan
- on the experiment list with infinite scroll enabled, scroll until you reach the second page (you can verify this by looking at the url -- it should contain the text
page=1
- select one or two items from the list
- refresh the page
- the items should appear selected with different colors
Commentary (optional)
Checklist
- [x] Changes have been manually QA'd
- [x] User-facing API changes need the "User-facing API Change" label.
- [x] Release notes should be added as a separate file under
docs/release-notes/
. See Release Note for details. - [x] Licenses should be included for new code which was copied and/or modified from any external code.
Ticket
no ticket
Deploy Preview for determined-ui ready!
Name | Link |
---|---|
Latest commit | b4655ba726f54bca5ae9d212e2a30a425ec71d8d |
Latest deploy log | https://app.netlify.com/sites/determined-ui/deploys/6632632cfe3d150008aeacd7 |
Deploy Preview | https://deploy-preview-9020--determined-ui.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Codecov Report
Attention: Patch coverage is 0%
with 2 lines
in your changes are missing coverage. Please review.
Project coverage is 37.96%. Comparing base (
abcc7b4
) to head (b4655ba
).
Additional details and impacted files
@@ Coverage Diff @@
## main #9020 +/- ##
==========================================
- Coverage 44.63% 37.96% -6.67%
==========================================
Files 1274 950 -324
Lines 156005 116213 -39792
Branches 2447 2446 -1
==========================================
- Hits 69629 44125 -25504
+ Misses 86137 71849 -14288
Partials 239 239
Flag | Coverage Ξ | |
---|---|---|
harness | ? |
|
web | 35.08% <0.00%> (+<0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Files | Coverage Ξ | |
---|---|---|
...bui/react/src/pages/F_ExpList/F_ExperimentList.tsx | 0.00% <0.00%> (ΓΈ) |