determined icon indicating copy to clipboard operation
determined copied to clipboard

chore: react-virtuoso LogViewer companion

Open EmilyBonar opened this issue 1 year ago β€’ 9 comments

Description

This is a companion PR to https://github.com/determined-ai/hew/pull/110.

Test Plan

Check Trial Logs, Task Logs, and Cluster Logs to ensure they all work as expected.

Commentary (optional)

Checklist

  • [ ] Changes have been manually QA'd
  • [ ] User-facing API changes need the "User-facing API Change" label.
  • [ ] Release notes should be added as a separate file under docs/release-notes/. See Release Note for details.
  • [ ] Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

EmilyBonar avatar Feb 20 '24 21:02 EmilyBonar

Deploy Preview for determined-ui ready!

Name Link
Latest commit 94c5d5e0dcadcade67e5ececdf738ff26465a26f
Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65ea06064a66f5000879282b
Deploy Preview https://deploy-preview-8862--determined-ui.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Feb 20 '24 21:02 netlify[bot]

iirc, we wanna resolve the double scrollbar issue, right (or is it out of scope)? if so, i still see the issue image


i see this bug in latest main, so not from this PR, but do you intend to fix this bug in this PR? The test plan scope isnt clear.

image

also, i saw some test failures.

keita-determined avatar Feb 21 '24 22:02 keita-determined

Noticed that TaskLogs.test.tsx was really just testing LogViewer behavior, so I moved it over to hew. Due to the differences in library implementation some of the test cases had to be removed as well.

EmilyBonar avatar Feb 23 '24 19:02 EmilyBonar

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 42.55%. Comparing base (6ecd81e) to head (94c5d5e). Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8862      +/-   ##
==========================================
- Coverage   47.35%   42.55%   -4.80%     
==========================================
  Files        1162      842     -320     
  Lines      176133   136781   -39352     
  Branches     2237     2233       -4     
==========================================
- Hits        83402    58211   -25191     
+ Misses      92573    78412   -14161     
  Partials      158      158              
Flag Coverage Ξ”
harness ?
web 42.51% <0.00%> (-0.03%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Ξ”
webui/react/src/pages/ClusterLogs.tsx 0.00% <0.00%> (ΓΈ)
.../react/src/pages/TrialDetails/TrialDetailsLogs.tsx 15.13% <0.00%> (+0.13%) :arrow_up:

... and 321 files with indirect coverage changes

codecov[bot] avatar Feb 23 '24 19:02 codecov[bot]

@keita-determined First bug should be fixed. The double scrollbar seems to be an issue with how the site as a whole handles resizing. In the last screenshot, I'm not sure what the issue is. The 16px margin is intentional and comes from Page.

EmilyBonar avatar Mar 04 '24 22:03 EmilyBonar

@keita-determined That search bug seems like a blocker, but I'm not able to repro it. Did you do anything special/unusual?

EmilyBonar avatar Mar 05 '24 21:03 EmilyBonar

@keita-determined That search bug seems like a blocker, but I'm not able to repro it. Did you do anything special/unusual?

i first typed test, and delete a letter one by one slowly, then i saw the issue. I tested on Chrome. Let me test it again cuz its rebased -> i can still reproduce it on Chrome and Firefox. i run it against latest-main.

keita-determined avatar Mar 05 '24 21:03 keita-determined

@keita-determined Good catch, seem like there was a bug regarding resetting our list of IDs for dupe detection. Try it now and it should work.

EmilyBonar avatar Mar 05 '24 22:03 EmilyBonar

yep, it works now

keita-determined avatar Mar 05 '24 22:03 keita-determined