determined
determined copied to clipboard
fix: allocation average time queued broken [DET-9709]
Description
The Avg Queue Time chart in http://{DET_MASTER}/det/resourcepool/default/stats has a queue time of thousands of years. Two reasons: k8s doesn't send allocation start time, and in agent we don't send allocation start time when we restore allocations. The start time is stored as 0001-01-01 00:00:00+00 in the DB.
Test Plan
e2e tests
Commentary (optional)
Checklist
- [ ] Changes have been manually QA'd
- [ ] User-facing API changes need the "User-facing API Change" label.
- [ ] Release notes should be added as a separate file under
docs/release-notes/
. See Release Note for details. - [ ] Licenses should be included for new code which was copied and/or modified from any external code.
Ticket
DET-9709
Deploy Preview for determined-ui canceled.
Name | Link |
---|---|
Latest commit | 0fe90e43b067e478f235b0d0d8b864f63b6d1290 |
Latest deploy log | https://app.netlify.com/sites/determined-ui/deploys/65b934ccc948570008afe3b9 |
Codecov Report
Attention: 6 lines
in your changes are missing coverage. Please review.
Comparison is base (
1e2da10
) 47.42% compared to head (0fe90e4
) 47.42%. Report is 2 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #8774 +/- ##
=======================================
Coverage 47.42% 47.42%
=======================================
Files 1047 1047
Lines 166976 166981 +5
Branches 2242 2242
=======================================
+ Hits 79185 79190 +5
Misses 87632 87632
Partials 159 159
Flag | Coverage Δ | |
---|---|---|
backend | 41.85% <14.28%> (+<0.01%) |
:arrow_up: |
harness | 64.36% <ø> (ø) |
|
web | 42.50% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Files | Coverage Δ | |
---|---|---|
master/internal/task/allocation.go | 76.32% <100.00%> (ø) |
|
master/pkg/model/task.go | 15.59% <ø> (ø) |
|
master/internal/rm/agentrm/resource_pool.go | 25.73% <0.00%> (-0.11%) |
:arrow_down: |
master/internal/rm/kubernetesrm/resource_pool.go | 0.00% <0.00%> (ø) |